Jenkinsfile: pull latest SDK from downloads server #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhil-zinjurde-imgtec
force-pushed
the
issue-46
branch
5 times, most recently
from
5fb60e4 to
7083502
Compare
Ham22
reviewed
Mar 23, 2017
Jenkinsfile
Outdated
| def url = new URL('http://downloads.creatordev.io/openwrt/release.json') | ||
| def object = jsonParse(url) | ||
| println object.versions.openwrt, object.board, object.versions.toolchain | ||
| def sdkUrl = [ |
There was a problem hiding this comment.
Using a format string would make this easier to read?
Jenkinsfile
Outdated
| def url = new URL('http://downloads.creatordev.io/openwrt/release.json') | ||
| def object = jsonParse(url) | ||
| println object.versions.openwrt, object.board, object.versions.toolchain | ||
| def sdkUrl = [ |
There was a problem hiding this comment.
perhaps add the word latest in the variable name?
Jenkinsfile
Outdated
|
|
||
| @NonCPS | ||
| def jsonParse(def json) { | ||
| def object = new JsonSlurper().parse(json) |
Jenkinsfile
Outdated
| object.versions.toolchain, | ||
| '.tar.bz2'].join() | ||
| println sdkUrl | ||
|
|
There was a problem hiding this comment.
Perhaps all of this should go in a function called getLatestSdkUrl?
nikhil-zinjurde-imgtec
force-pushed
the
issue-46
branch
5 times, most recently
from
f6ed8c4 to
1756a94
Compare
Signed-off-by: Nikhil Zinjurde <[email protected]>
nikhil-zinjurde-imgtec
force-pushed
the
issue-46
branch
from
1756a94 to
4b41152
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #46
Signed-off-by: Nikhil Zinjurde [email protected]